Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply "Initial refactoring of incremental materialization" #1123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Apply "Initial refactoring of incremental materialization" #1123

wants to merge 4 commits into from

Conversation

hiloboy0119
Copy link

Problem

dbt-spark uses the old method of applying incremental materialization macros.

This PR is a draft because I also dropped support for python 3.8 to get tests to pass. I will remove that commit when pull/1121 is merged

Solution

Applies "Initial refactoring of incremental materialization" (dbt-labs/dbt-core#5359).

Now it uses adapter.get_incremental_strategy_macro instead of dbt-spark's dbt_spark_get_incremental_sql macro to dispatch the incremental strategy macro.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • [] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hiloboy0119 hiloboy0119 changed the title [DRAFT] Apply "Initial refactoring of incremental materialization"Incremental refactor [DRAFT] Apply "Initial refactoring of incremental materialization" Oct 17, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 17, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Drew Goya.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@hiloboy0119
Applies "Initial refactoring of incremental materialization" (dbt-lab…
f2f771b 
…s/dbt-core#5359).

Now it uses `adapter.get_incremental_strategy_macro` instead of
dbt-spark's `dbt_spark_get_incremental_sql` macro to dispatch the
incremental strategy macro.

Add tests that check for the new error string
@hiloboy0119
Upgrade hudi to working version for spark 3.3
5637b98
@hiloboy0119
Bringing minimum python version up to 3.9 to match dbt-core
f3cb955
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 17, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @hiloboy0119

@hiloboy0119 hiloboy0119 marked this pull request as ready for review October 17, 2024 16:56
@hiloboy0119 hiloboy0119 requested a review from a team as a code owner October 17, 2024 16:56
@hiloboy0119 hiloboy0119 changed the title [DRAFT] Apply "Initial refactoring of incremental materialization" Apply "Initial refactoring of incremental materialization" Oct 17, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 17, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @hiloboy0119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hiloboy0119